feat(account): add includeOperations option to account transactions (#563) - #655
Open
Loisyy wants to merge 2 commits into
Open
feat(account): add includeOperations option to account transactions (#563)#655Loisyy wants to merge 2 commits into
Loisyy wants to merge 2 commits into
Conversation
…lve leftover merge artifacts from stellarkit-lab-devtools#649
…ctions Adds an optional ?includeOperations query parameter to GET /account/:id/transactions. When true, each transaction gets a normalised operations array embedded under 'operations', using the same shape as GET /transactions/:id/operations. Default behaviour (omitted or false) is unchanged - no operations field, no extra Horizon calls. - src/utils/operationFormatter.js: new normalizeOperation() helper, extracted from the shape used by GET /transactions/:id/operations, so both endpoints share one normalised operation shape - src/routes/account.js: formatTx is now async; when includeOperations is set, fetches server.operations().forTransaction(hash) per transaction and embeds the normalised records; falls back to an empty array (not an error) if a lookup fails - src/middleware/coerceQueryParams.js: coerce ?includeOperations to boolean - tests/account.transactions.includeOperations.test.js: covers includeOperations=true embedding operations, per-type shape (payment/create_account/change_trust), default/false behaviour unchanged, multiple transactions handled independently, and graceful fallback on lookup failure Closes stellarkit-lab-devtools#563
|
@Loisyy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements issue #563 by adding support for the optional
?includeOperations=truequery parameter on:GET /account/:id/transactions
When the parameter is provided, each transaction includes its normalized
operations array. When omitted, the existing response format is preserved.
Changes
includeOperations=trueTesting
?includeOperations=trueembeds normalized operationsCloses #563